Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(README): update README.md to include latest codemods #780

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

adamviktora
Copy link
Contributor

Updates README.md

I had to include missing Input.tsx and Output.tsx in one of the rules in order for the buildReadme.ts script to work. Should I instead modify the script so the input / output example files are not required?

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should update the script so that it can handle rules without the input/output files. It isn't like they really do a lot of good for non-fix rules anyways.

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wise-king-sullyman wise-king-sullyman merged commit ce72533 into patternfly:main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants