feat(DataListAction): Remove isPlainButtonAction prop #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
reviewed
Sep 23, 2024
| import { DataListAction } from "@patternfly/react-core"; | ||
|
|
||
| export const DataListActionRemoveIsPlainButtonActionPropInput = () => ( | ||
| <DataListAction /> |
There was a problem hiding this comment.
The isPlainButtonAction prop is missing here
thatblindgeye
requested changes
Sep 24, 2024
| @@ -0,0 +1,17 @@ | |||
| ### dataListAction-remove-isPlainButtonAction-prop [(#10939)](https://github.com/patternfly/patternfly-react/pull/10934) | |||
There was a problem hiding this comment.
Suggested change
| ### dataListAction-remove-isPlainButtonAction-prop [(#10939)](https://github.com/patternfly/patternfly-react/pull/10934) | |
| ### dataListAction-remove-isPlainButtonAction-prop [(#10939)](https://github.com/patternfly/patternfly-react/pull/10939) |
| @@ -0,0 +1,17 @@ | |||
| ### dataListAction-remove-isPlainButtonAction-prop [(#10939)](https://github.com/patternfly/patternfly-react/pull/10934) | |||
|
|
|||
| The `isPlainButtonAction` prop has been removed from DataListAction as a wrapper is no longer needed when there is a plain button action. | |||
There was a problem hiding this comment.
Based on Michael's comments, maybe something like the following would be more accurate?
Suggested change
| The `isPlainButtonAction` prop has been removed from DataListAction as a wrapper is no longer needed when there is a plain button action. | |
| The `isPlainButtonAction` prop has been removed from DataListAction as a wrapper is no longer needed. |
Since he had mentioned now applying some styling for non-plain actions as well. If this gets updated we should update the error message in the rule + tests as well.
thatblindgeye
approved these changes
Sep 24, 2024
adamviktora
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #762