feat(EmptyState): make titleText optional #770
Merged
+60
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
approved these changes
Sep 18, 2024
...ods/src/rules/v6/emptyStateHeaderMoveIntoEmptyState/emptyStateHeader-move-into-emptyState.ts
Show resolved
Hide resolved
...ods/src/rules/v6/emptyStateHeaderMoveIntoEmptyState/emptyStateHeader-move-into-emptyState.ts
Show resolved
Hide resolved
Comment on lines
239
to
244
| (hasChildren | ||
| ? `titleText=${getChildrenAsAttributeValueText( | ||
| context, | ||
| header.children | ||
| )}` | ||
| : ""); |
There was a problem hiding this comment.
And one nit here: can you refactor this in a simpler way than having a ternary nested inside of an or statement?
Comment on lines
237
to
243
| const createTitleTextPropFromChildren = () => | ||
| hasChildren | ||
| ? `titleText=${getChildrenAsAttributeValueText( | ||
| context, | ||
| header.children | ||
| )}` | ||
| : ""); | ||
| : ""; |
There was a problem hiding this comment.
One more even smaller nit, is there an advantage to this being a function rather than just doing something like
const childrenTitleText = hasChildren ? <title text> : ""
There was a problem hiding this comment.
Oh, you are right, my thought around this was that if titleTextPropValue is not an empty string, then the second part of the OR operator won't be evaluated. But the function is super simple, so I guess it really doesn't make any difference performance-wise (and it is Javascript, so it's slow anyways)
wise-king-sullyman
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #764