feat(tokens): warn for CSS variables in strings #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "global_warning_color_100", | ||
| "global_warning_color_200", | ||
| ]; | ||
| // consumers may run class-name-updater before codemods, so we have to check also old tokens with v6 prefix |
There was a problem hiding this comment.
Is this still applicable after changes made in #754 ?
There was a problem hiding this comment.
We probably don't need it, at least not for the global tokens. Related to component tokens, I posted an issue with that on slack, they will still get updated to v6.
I would rather keep it there if someone has already run the old version of class-name-updater, but if you think it is not necessary, we can remove it
There was a problem hiding this comment.
I would rather keep it there if someone has already run the old version of class-name-updater
I'm good with keeping it for this
thatblindgeye
approved these changes
Aug 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #748
Provides warnings also for variables in strings.
We might want to merge this now, so consumers have at least warnings, that this token is old and I'll work on the fixer as a followup.