Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(design-accessibility): update v6 images #4297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrew-ronaldson
Copy link
Contributor

Closes #4295
Updating two images on the design for accessibility page with v6 styling

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 3, 2024

Copy link
Collaborator

@edonehoo edonehoo Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a hyphen to "red-green" 🤓 in the caption

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be crazy but is there an extra space in the caption between "and irrelevant"?

@edonehoo
Copy link
Collaborator

edonehoo commented Oct 4, 2024

as an fyi side note, I've been storing all of my images that I use on org in this figma workspace (I will add you manually to avoid posting an edit link): https://www.figma.com/design/FI2WrSBQ9d357XUI6uCE6V/PatternFly.org-image-assets?node-id=0-1&t=sqdIEDekFINi2VdS-1

idk if it's easy to copy your changes into there/send them to me/get to it later, but would maybe be good for longer term maintenance to keep it in a single area. since I've been the only one really changing images in prs, I'm the only one who uses this though, so maybe there's a better solution long-term

Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huzzah 🤴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guideline updates: Design for accessibility page
3 participants