Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: Fix a broken debug scope assert #96

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Spec: Fix a broken debug scope assert #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,11 @@ To <dfn algorithm export>append an entry to the contribution cache</dfn> given a
1. [=list/Append=] |entry| to the [=contribution cache=].

To <dfn algorithm export>get a debug details</dfn> given a [=debug scope=]
|debugScope|:
|debugScope|, perform the following steps. They return a [=debug details=].
1. Let |debugScopeMap| be the [=debug scope map=].
1. [=Assert=]: |debugScopeMap|[|debugScope|] [=map/exists=].

Issue: This should return a default when the scope does not exist.
1. Return |debugScopeMap|[|debugScope|].
1. If |debugScopeMap|[|debugScope|] [=map/exists=], return
|debugScopeMap|[|debugScope|].
1. Otherwise, return a new [=debug details=].

To <dfn algorithm export>mark a debug scope complete</dfn> given a [=debug
scope=] |debugScope|:
Expand Down