Skip to content

Commit

Permalink
Spec: Fix a broken assert (#96)
Browse files Browse the repository at this point in the history
Instead of asserting, we should return a default value to match the
implementation.
  • Loading branch information
alexmturner authored Sep 26, 2023
1 parent 43a7bef commit 0ca85d9
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,11 @@ To <dfn algorithm export>append an entry to the contribution cache</dfn> given a
1. [=list/Append=] |entry| to the [=contribution cache=].

To <dfn algorithm export>get a debug details</dfn> given a [=debug scope=]
|debugScope|:
|debugScope|, perform the following steps. They return a [=debug details=].
1. Let |debugScopeMap| be the [=debug scope map=].
1. [=Assert=]: |debugScopeMap|[|debugScope|] [=map/exists=].

Issue: This should return a default when the scope does not exist.
1. Return |debugScopeMap|[|debugScope|].
1. If |debugScopeMap|[|debugScope|] [=map/exists=], return
|debugScopeMap|[|debugScope|].
1. Otherwise, return a new [=debug details=].

To <dfn algorithm export>mark a debug scope complete</dfn> given a [=debug
scope=] |debugScope|:
Expand Down

0 comments on commit 0ca85d9

Please sign in to comment.