-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and publish SDK docs in gh-pages #95
Conversation
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
1 similar comment
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
1 similar comment
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Hey, nice job, do we really need to commit all assets including build files ? |
That a good question, should be a way to publish those without having them committed (at least not in main branch). -- |
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtme ! just changing the branches and ready to merge :)
.github/workflows/documentation.yml
Outdated
|
||
on: | ||
push: | ||
branches: [nik-add-docs-in-CI] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just modify this to "main" and should be good for merge 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still testing.. this is not working
.github/workflows/documentation.yml
Outdated
push: | ||
branches: [nik-add-docs-in-CI] | ||
pull_request: | ||
branches: [nik-add-docs-in-CI] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still testing.. this is not working
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
1 similar comment
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
1 similar comment
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
1 similar comment
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
f4de18a
to
d44088e
Compare
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Coverage after merging nik-add-docs-in-CI into main
Coverage Report
|
Fixes #94