Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTP response headers available via client #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Posnet
Copy link

@Posnet Posnet commented Mar 24, 2022

I've found that I need to inspect the response headers from the http upgrade request.
This pull request copies the headers from the parsed response into the client.
I realize this is a niche use case and may not make sense for inclusion. But I'd thought I'd check anyway.

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your PR

I found it a bit surprising to add the response headers to the Client itself, can you explain why you didn't add it ServerResponse instead?

Otherwise, looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants