Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyO3: migrate to Bound smart pointer for src/rust/engine/src/externs/engine_aware.rs #21470

Merged

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Oct 2, 2024

Migrate to the Bound smart pointer instead of &PyAny (and related reference types) in src/rust/engine/src/externs/engine_aware.rs. See the PyO3 migration guide for details.

@tdyas tdyas added category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes labels Oct 2, 2024
@tdyas tdyas requested review from benjyw and huonw October 2, 2024 01:35
@tdyas tdyas enabled auto-merge (squash) October 2, 2024 01:38
@tdyas tdyas merged commit 7a5c2cd into pantsbuild:main Oct 2, 2024
25 checks passed
@tdyas tdyas deleted the pyo3_switch_to_bound_in_externs_engine_aware branch October 5, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants