Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe Reviewers and TeamReviewers before submitting them to GitHub #856

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

FraBle
Copy link
Contributor

@FraBle FraBle commented Oct 3, 2024

Fixes #855

The code takes the same deduping method as the DetailsReviewers handler.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/policy-bot, @FraBle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@FraBle
Copy link
Contributor Author

FraBle commented Oct 3, 2024

I signed the CLA

maschwenk
maschwenk previously approved these changes Oct 3, 2024
@policy-bot policy-bot bot dismissed maschwenk’s stale review October 3, 2024 19:53

Invalidated by push of a3e0000

@bluekeyes bluekeyes merged commit 2c98d7d into palantir:develop Oct 3, 2024
8 checks passed
@bluekeyes
Copy link
Member

Thanks for the PR. You can test this out using the palantirtechnologies/policy-bot:snapshot image - if it fixes the problem, I can make a new release.

@FraBle
Copy link
Contributor Author

FraBle commented Oct 3, 2024

@bluekeyes Confirmed. The snapshot works fine for us now. 💯

@bluekeyes
Copy link
Member

Thanks for verifying, 1.36.1 is out now with the fix

@maschwenk
Copy link
Contributor

@bluekeyes @FraBle thank you! that turnaround time was amazing!

@FraBle FraBle deleted the fb-dedupe branch October 4, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request / Github API bug workaround - deduplicate team review requests before send
4 participants