-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip reviewer assignment on comment/review events (#307)
With the current set of predicates, these events can never change the set of requested reviewers or trigger a re-request so there's no reason to do the work of computing and assigning reviewers. This is an alternate solution to the re-request loops that I fixed by including head commit reviews in the set of reviewers. I think the other approach is more correct, but this doesn't hurt. The main downside is that if we add predicates that use comments or reviews in the future, it will be easy to forget to change this trigger condition and it might be a while before someone reports unexpected behavior with the new predicate and reviewer assignment.
- Loading branch information
Showing
2 changed files
with
11 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters