Add support for Composer in purl2url #144
Conversation
|
@camillem That's great! Could you add the url2purl side as well? |
camillem
changed the title
Yep, I'll do that. |
src/packageurl/contrib/purl2url.py
Outdated
| """ | ||
| purl_data = PackageURL.from_string(purl) | ||
|
|
||
| name = (purl_data.name or "").replace("_", "-") |
There was a problem hiding this comment.
I'm that sure that an empty name is ever possible, see https://github.com/camillem/packageurl-python/blob/e0d180d1ce23f289230a970c2d1e560456300bb8/src/packageurl/__init__.py#L542
There was a problem hiding this comment.
Indeed. I just directly copy/pasted it from https://github.com/camillem/packageurl-python/blob/e0d180d1ce23f289230a970c2d1e560456300bb8/src/packageurl/contrib/purl2url.py#L219
I should also check if the replace("_", "-") makes sense in this context.
There was a problem hiding this comment.
I simplified this part, as the replace("_", "-") seemed to be linked to an old pypi.org oddity.
Signed-off-by: Camille Moulin <[email protected]>
camillem
changed the title
Signed-off-by: tdruez <[email protected]>
|
Thanks @camillem for your contribution 🚀 |
Hi,
I have tried to add support for Composer to purl2url.
It might be relevant to #143
Cheers,
Camille