Reorder subdirectory additions in CMakeLists.txt #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang, Han2 <[email protected]>
fruffy
added
the
core
fruffy
approved these changes
Oct 2, 2024
grg
approved these changes
Oct 2, 2024
ChrisDodd
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
The ir generator is supposed to reorder and forward declare things as needed, so the order of the .def files/directories should not matter, and you don't need to declare things before you use them. So if there are cases it is mis-ordering things in ir-generated.h, then it should be fixed there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move add_subdirectory commands for frontends, midend, and control-plane before the extension processing loop. This ensures that classes declared in ir-generated.h from the frontends is available when processing extensions.