Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser symbolic interpreter to evaluate StringLiteral #4937

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix parser symbolic interpreter to evaluate StringLiteral #4937

merged 1 commit into from
Oct 3, 2024

Conversation

jhavrane
Copy link
Contributor

@jhavrane jhavrane commented Oct 2, 2024

Add support for StringLiteral in ExpressionEvaluator. Fixes #4932

@jhavrane jhavrane added bug This behavior is unintended and should be fixed. core Topics concerning the core segments of the compiler (frontend, midend, parser) labels Oct 2, 2024
@jhavrane jhavrane self-assigned this Oct 2, 2024
fruffy
fruffy approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know the symbolic interpreter code well, but this looks reasonable to me.

This PR is missing a DCO commit.

@jhavrane jhavrane marked this pull request as ready for review October 3, 2024 07:26
@jhavrane jhavrane added this pull request to the merge queue Oct 3, 2024
Merged via the queue into p4lang:main with commit b8edc2c Oct 3, 2024
19 checks passed
@jhavrane jhavrane deleted the jhavrane/fix_4932 branch October 3, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

Assignees

@jhavrane jhavrane

Labels
bug This behavior is unintended and should be fixed. core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser symbolic interpreter unable to evaluate StringLiteral
2 participants
@jhavrane @fruffy