feat(oxlint): auto detect config file in CLI #7348
Open
+89
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-cli
This was referenced Nov 19, 2024
Boshen
pushed a commit
that referenced
this pull request
Nov 20, 2024
allows to use multiple `LintRunner` in one file targeting multiple directory. The current problem is for the test in #7348 we can not change `env::current_dir`, so as a workaround I introduce a new property :) See more info here: https://discord.com/channels/1079625926024900739/1117322804291964931/1308179827576016897
camc314
reviewed
Nov 20, 2024
| let result = test_with_cwd("fixtures/auto_config_detection", args); | ||
| assert_eq!(result.number_of_files, 1); | ||
| assert_eq!(result.number_of_warnings, 0); | ||
| assert_eq!(result.number_of_errors, 1); |
There was a problem hiding this comment.
isn't debugger on by default since it's in correctness ?
so if it failed to pick up the config, it would still return 1 here
There was a problem hiding this comment.
It will output it as an warning not an error.
Deleting the oxlint.json the assertion should be:
assert_eq!(result.number_of_warnings, 1);
assert_eq!(result.number_of_errors, 0);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting fior #7352