New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Process.setTitle #14306

Open

CarlosEduR wants to merge 1 commit into oven-sh:main from CarlosEduR:fix/process-title-setter

CarlosEduR commented Oct 2, 2024

What does this PR do?

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

Unit test added
ran locally and confirmed it works

Zig files changed:

needs review

I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
I included a test for the new code, or an existing test covers it
JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)


          fix Process.setTitle and update getTitle

8cb1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet