Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address assertion failure in node:fs #14265

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@robobun
Copy link

robobun commented Oct 1, 2024

@Jarred-Sumner, your commit 02aebfe has 18 failures in #4122:

  • test/regression/issue/ctrl-c.test.ts - illegal instruction at address 0x7ff8059f137b on 🍎 13 x64
  • test/cli/install/bun-install.test.ts - timeout on 🍎 13 x64
  • test/v8/v8.test.ts - 24 failing on 🐧 20.04 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64
  • test/package.json - timeout on 🐧 22.04 x64
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 12 x64
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/node/fs/fs-oom.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 x64
  • test/js/node/watch/fs.watch.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 13 aarch64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 x64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64
  • test/js/bun/http/bun-serve-static.test.ts - annotation error on 🍎 13 aarch64
  • test/js/node/fs/fs.test.ts - 4 failing on 🍎 14 aarch64
  • test/js/node/fs/fs.test.ts - 4 failing on 🪟 x64
  • test/js/node/fs/fs.test.ts - 4 failing on 🍎 13 aarch64
  • test/js/node/fs/fs.test.ts - 4 failing on 🪟 x64-baseline
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 20.04 x64
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 20.04 x64-baseline
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 22.04 x64-baseline
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 12 x64-baseline
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 22.04 x64
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 12 x64
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 22.04 aarch64
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 12 aarch64
  • test/js/node/fs/fs.test.ts - 4 failing on 🐧 20.04 aarch64
  • test/js/node/fs/fs.test.ts - 4 failing on 🍎 13 x64
  • test/js/node/fs/fs.test.ts - 4 failing on 🍎 14 x64
  • test/cli/install/bun-link.test.ts - 1 failing on 🪟 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🪟 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 12 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🍎 13 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🍎 14 x64
  • test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 14 aarch64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64
  • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants