'let' statements before using statements are now properly converted into 'var' statements #14260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
requested changes
Oct 1, 2024
| continue; | ||
| if (p.const_values.contains(decl.binding.data.b_identifier.ref)) { | ||
| any_decl_in_const_values = true; | ||
| const symbol = p.symbols.items[decl.binding.data.b_identifier.ref.innerIndex()]; |
There was a problem hiding this comment.
Suggested change
| const symbol = p.symbols.items[decl.binding.data.b_identifier.ref.innerIndex()]; | |
| const symbol = &p.symbols.items[decl.binding.data.b_identifier.ref.innerIndex()]; |
src/js_parser.zig
Outdated
| } | ||
| } | ||
| decls[end] = decl; | ||
| end += 1; | ||
| } | ||
| local.decls.len = @as(u32, @truncate(end)); | ||
| if (end == 0) { | ||
| stmt.* = stmt.*.toEmpty(); | ||
| if (any_decl_in_const_values) { |
There was a problem hiding this comment.
should this if be there? i'm confused
There was a problem hiding this comment.
it's the only side effect that happens if it being const/in const_values is true. so we don't want it to happen if the check is false
There was a problem hiding this comment.
(the locals.decls.len assignment is a no-op if it's false because end will be the len value. it should probably be moved into the if statement too though then)
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #12407 and the regression demonstrated in #11083 where a
letstatement before ausingwould not be converted into avarso anything referencing it outside of the generated try/catch would raise aReferenceErrorHow did you verify your code works?