Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13816 #13906

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fixes #13816 #13906

wants to merge 11 commits into from
+139 −28

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

I wanted to go and make some changes to #13840, so here's a slightly revised version with test failures hopefully fixed

Closes #13840
Fixes #13816

How did you verify your code works?

Tests

@refi64 @Jarred-Sumner
Add $ERR_STREAM_RELEASE_LOCK
a4ded20 
Ignore ERR_STREAM_RELEASE_LOCK in process.stdin

Reject pending reads when a ReadableStream's lock is released

WebKit/WebKit@f8ae40c

Update the ReadableStream promise resolution ordering on pull rejection

WebKit/WebKit@1f74c15

Fix pipeThrough unhandled rejections on readable errors

WebKit/WebKit@07e4b92

Fix pipeTo unhandled rejections on readable errors

WebKit/WebKit@3a75b5d

Fixes #13816.
@robobun
Copy link

robobun commented Sep 12, 2024 •
edited
Loading

❌ @Jarred-Sumner, your commit 4ff477b has 10 failures in #4337:

  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 12 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 13 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 14 x64
  • test/js/node/zlib/leak.test.ts - 1 failing on 🪟 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 aarch64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🪟 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 12 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 13 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 14 x64
  • test/bundler/bundler_compile.test.ts - 5 failing on 🪟 x64
  • test/bundler/bundler_compile.test.ts - 4 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/bundler/bundler_edgecase.test.ts - 1 failing on 🪟 x64
  • test/js/bun/http/bun-serve-static.test.ts - 5 failing on 🍎 13 aarch64
    		•

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    releasing lock of reader whose stream is still in readable state when cancelling a TransformStream
    3 participants
    @Jarred-Sumner @robobun @refi64