Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(model): Clarify an Identifier's project vs. package use #9228

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

sschuberth
Copy link
Member

It does not make sense to limit the type to a package if the next sentence explains that it can be used for a project as well.

@sschuberth sschuberth requested a review from a team as a code owner October 1, 2024 14:56
@sschuberth sschuberth enabled auto-merge (rebase) October 1, 2024 14:56
@sschuberth sschuberth marked this pull request as draft October 1, 2024 15:00
auto-merge was automatically disabled October 1, 2024 15:00

Pull request was converted to draft

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (8b030ab) to head (0f1854a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9228   +/-   ##
=========================================
  Coverage     67.65%   67.65%           
  Complexity     1185     1185           
=========================================
  Files           239      239           
  Lines          7795     7795           
  Branches        899      899           
=========================================
  Hits           5274     5274           
  Misses         2153     2153           
  Partials        368      368           
Flag Coverage Δ
funTest-docker 60.23% <ø> (ø)
funTest-non-docker 34.71% <ø> (ø)
test 37.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth changed the title docs(model): Clarify the docs for an Identifier's type docs(model): Clarify an Identifier's project vs. package use Oct 1, 2024
@sschuberth sschuberth marked this pull request as ready for review October 1, 2024 15:16
Use "component" as a neutral umbrella term for project and package, and
"ecosystem" for the name giver of the type of a package's identifier.

Signed-off-by: Sebastian Schuberth <[email protected]>
Avoid confusion with a "software component".

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth merged commit 6ab1310 into main Oct 4, 2024
23 checks passed
@sschuberth sschuberth deleted the project-vs-package-id branch October 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants