Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distro/fedora: add support for Fedora 39 #3324

Merged
merged 1 commit into from
Mar 15, 2023
Merged

distro/fedora: add support for Fedora 39 #3324

merged 1 commit into from
Mar 15, 2023

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Mar 7, 2023

Add F39 repositories, see #3306.

thozza
thozza previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

thozza
thozza previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, image test manifests 🥲

@supakeen
Copy link
Member Author

supakeen commented Mar 8, 2023

yay, image test manifests smiling_face_with_tear

One of those days, when it turns green I'll merge :)

ondrejbudai
ondrejbudai previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

schutzbot
schutzbot reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 925b25c with the main merge-base 0e4a5b3). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3894583071/artifacts/browse

@supakeen
Copy link
Member Author

supakeen commented Mar 8, 2023

@thozza @ondrejbudai I see that normally the generate-test-data/repos.json file refers to our snapshots, how do I add f39 to that?

@ondrejbudai
Copy link
Member

@thozza @ondrejbudai I see that normally the generate-test-data/repos.json file refers to our snapshots, how do I add f39 to that?

You need to add F39 into rpmrepo and make a new snapshot, see https://github.com/osbuild/rpmrepo. The recent commit history should be pretty helpful. :)

@supakeen supakeen dismissed stale reviews from ondrejbudai and thozza via 987f7ef March 13, 2023 10:37
schutzbot
schutzbot reviewed Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 987f7ef with the main merge-base 0e4a5b3). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3921228198/artifacts/browse

thozza
thozza previously approved these changes Mar 13, 2023
View reviewed changes
@thozza thozza dismissed their stale review March 13, 2023 16:08

I noticed that image test manifests do not use the RPMRepos snapshots. You'll need to regenerate them with the updated repo definitions used for these...

schutzbot
schutzbot reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 454c1df with the main merge-base 0e4a5b3). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3929702057/artifacts/browse

thozza
thozza reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that tie problem with image test manifests should be fixed now based on what I sanity-checked.

However the added test/data/repositories/fedora-38.json file is weird...

test/data/repositories/fedora-38.json Outdated Show resolved Hide resolved
@supakeen supakeen force-pushed the enable-f39 branch 3 times, most recently from 58ebb0f to 55b02e9 Compare March 14, 2023 15:47
thozza
thozza previously approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

schutzbot
schutzbot reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 55b02e9 with the main merge-base 4023b61). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3931715119/artifacts/browse

schutzbot
schutzbot reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 0f21f63 with the main merge-base 4023b61). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3933402299/artifacts/browse

@supakeen
Copy link
Member Author

@thozza, @ondrejbudai this is now green. I hope I found all the locations.

thozza
thozza approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thanks!

@thozza thozza merged commit 23627e9 into osbuild:main Mar 15, 2023
@supakeen supakeen deleted the enable-f39 branch March 15, 2023 09:42
@jkonecny12
Copy link

jkonecny12 commented Jun 30, 2023 •
edited
Loading

Hi, when this will be available on packit build in-image-builder? I still see here just Fedora 38.

@supakeen supakeen self-assigned this Jul 3, 2023
@ondrejbudai
Copy link
Member

@supakeen sorry, missed the assigments.

@jkonecny12: Once osbuild/image-builder#776 gets merged and deployed. Sorry, we apparently forgot to do the last step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

@thozza thozza thozza approved these changes

@ondrejbudai ondrejbudai ondrejbudai left review comments

Assignees

@supakeen supakeen

Labels
None yet
Projects
Building Fedora
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@supakeen @ondrejbudai @jkonecny12 @thozza @schutzbot