Helm chart container image related parameter (pullsecret, pullpolicy) support added. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
europ
changed the title
europ
force-pushed
the
missing_parameter
branch
2 times, most recently
from
11e6f23 to
0a4c9b3
Compare
| @@ -25,11 +25,12 @@ spec: | |||
| fsGroup: {{ default 0 .Values.deployment.security.fsGroup }} | |||
| serviceAccountName: {{ include "mgmt-agent.serviceAccount" . }} | |||
| imagePullSecrets: | |||
| - name: {{ include "mgmt-agent.resourceNamePrefix" . }}-mgmt-agent-container-registry-key | |||
There was a problem hiding this comment.
@niravg75 , please review the Mgmt Agent changes suggested in this PR.
* image url * image pull secret * image pull policy
europ
force-pushed
the
missing_parameter
branch
from
0a4c9b3 to
3a7b13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Added support for currently not supported parameters:
Modified parameter: