Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump catalogd to v0.30.0 #1329

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner October 3, 2024 01:03
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e1f7cfc
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66ff21258724300008af4616
😎 Deploy Preview https://deploy-preview-1329--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.65%. Comparing base (814bf63) to head (e1f7cfc).

Files with missing lines Patch % Lines
...nternal/controllers/clusterextension_controller.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (814bf63) and HEAD (e1f7cfc). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (814bf63) HEAD (e1f7cfc)
unit 2 1
e2e 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1329       +/-   ##
===========================================
- Coverage   76.37%   53.65%   -22.73%     
===========================================
  Files          41       41               
  Lines        2438     2438               
===========================================
- Hits         1862     1308      -554     
- Misses        402     1027      +625     
+ Partials      174      103       -71     
Flag Coverage Δ
e2e 0.00% <0.00%> (-58.45%) ⬇️
unit 53.65% <87.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LalatenduMohanty
Copy link
Member

@joelanford This PR needs rebase.

@joelanford
Copy link
Member Author

After this merges, we'll need to change hack/test/pre-upgrade-setup.sh to account for the new catalogd revision being used (and the API changes that brings)

Signed-off-by: Joe Lanford <[email protected]>
@joelanford
Copy link
Member Author

The upgrade-e2e is expected to fail here. We made breaking changes in catalogd, so the failure is a true positive.

https://github.com/operator-framework/operator-controller/actions/runs/11170964356/job/31054808071?pr=1329#step:4:413

This error is happening because the ClusterCatalog that we create prior to the upgrade has spec.source.type: "image", but after the upgrade, catalogd requires spec.source.type: "Image" and no longer understands how to process "image". Therefore the ClusterCatalog never progresses to having a Serving condition.

I think this PR is ready to merge.

@joelanford joelanford added this pull request to the merge queue Oct 4, 2024
Merged via the queue into operator-framework:main with commit e57525e Oct 4, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants