🌱 make post-upgrade-e2e checks wait for ClusterCatalog to be reconciled #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
force-pushed
the
fix-e2e-race
branch
from
4bf0752
to
6b53d11
Compare
…ciled Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
fix-e2e-race
branch
from
6b53d11
to
59bf6c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 38.04% 37.89% -0.15%
==========================================
Files 15 15
Lines 786 789 +3
==========================================
Hits 299 299
- Misses 443 446 +3
Partials 44 44 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
Sep 18, 2024
|
What's going on with the go-verdiff check? |
Merged
via the queue into
operator-framework:main
with commit Sep 18, 2024
f0ef22a
11 of 14 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the post-upgrade-e2e checks were actually making assertions on the ClusterCatalog before it had a change to be reconciled by the upgraded catalogd instance. This PR should fix that.