Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ use controller-runtime Terminal error instead of custom Unrecoverable error #405

Merged

Conversation

joelanford
Copy link
Member

Fixes #400

@joelanford joelanford requested a review from a team as a code owner September 17, 2024 21:37
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.43%. Comparing base (8c6625f) to head (d1bf532).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/source/containers_image.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   37.45%   37.43%   -0.02%     
==========================================
  Files          15       14       -1     
  Lines         793      788       -5     
==========================================
- Hits          297      295       -2     
+ Misses        449      446       -3     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented Sep 18, 2024

We have a TerminalError‽‽

@joelanford
Copy link
Member Author

@tmshort controller-runtime does! And it serves the same purpose, except with controller-runtime integration (e.g. for tracking terminal error metrics)

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@joelanford joelanford added this pull request to the merge queue Sep 18, 2024
Merged via the queue into operator-framework:main with commit d12e611 Sep 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instead of custom Unrecoverable error, use controller-runtime's TerminalError
4 participants