🐛 Fix unnecessary lastUnpacked status updates

[m1kola]

We should not be updating lastUnpacked status fields when we read from the cache

Fixes #389

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.55%. Comparing base (8e71e93) to head (9e007c1).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   35.29%   35.55%   +0.26%     
==========================================
  Files          17       17              
  Lines         731      734       +3     
==========================================
+ Hits          258      261       +3     
  Misses        443      443              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[perdasilva]

lgtm ^^

[perdasilva]

doh - didn't realize it was draft - apologies

[m1kola]

Ready for review now

[perdasilva]

Previously, we'd be updating the last unpacked time on every reconcile if the unpack directory (given by the catalog name and the image digest) already exists. In this PR we address this by checking if the ResolvedSource.Image is set and taking the last unpack time from that. Otherwise, set last unpacked to now. LGTM.

My only question is whether we ought to add a test where Status.ResolvedSource or Status.ResolvedSource.Image isn't set.

[m1kola]

My only question is whether we ought to add a test where Status.ResolvedSource or Status.ResolvedSource.Image isn't set.

@perdasilva this question made me think that we should probably set LastUnpacked to "now" if we do not have a value in the status.

We already had several test cases where we do not set this status field, but we had not assertions on ResolvedSource.Image.LastUnpacked in the result struct. Now we do: we check that the LastUnpacked is not zero time value.

PR updated. Please take another look.

[perdasilva]

lgtm ^^ thank you!