-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Capture catalog content timestamp in ClusterCatalogStatus #334
✨ Capture catalog content timestamp in ClusterCatalogStatus #334
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 34.13% 34.27% +0.13%
==========================================
Files 15 15
Lines 665 674 +9
==========================================
+ Hits 227 231 +4
- Misses 414 417 +3
- Partials 24 26 +2 ☔ View full report in Codecov by Sentry. |
df6dd1f
to
9a7a079
Compare
It won't let me put a comment on it, but at https://github.com/operator-framework/catalogd/pull/334/files#diff-d446855f2187e6d61c4719c3202fcb21e4aea9b09e09f9e1d01419f341d8fc9fR51 //+kubebuilder:printcolumn:name=UnpackedTime,type=date,JSONPath=`.metadata.catalogContentTimestamp Totally flexible about the name ... but |
config/base/crd/bases/catalogd.operatorframework.io_clustercatalogs.yaml
Outdated
Show resolved
Hide resolved
0f4bb34
to
907df6f
Compare
ac8f6aa
to
b5e7d4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me based on my understanding of the goals of this PR.
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
b5e7d4a
to
de3210f
Compare
Merging this PR since it was approved. upgrade-e2e will fail until a new release of catalogd is cut with the gvk updates. |
3b4c5f6
fixes #306 out of the epic #239