Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Capture catalog content timestamp in ClusterCatalogStatus #334

Conversation

rashmigottipati
Copy link
Member

fixes #306 out of the epic #239

@rashmigottipati rashmigottipati requested a review from a team as a code owner August 1, 2024 11:39
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 34.27%. Comparing base (1213f56) to head (de3210f).

Files Patch % Lines
...rnal/controllers/core/clustercatalog_controller.go 62.50% 1 Missing and 2 partials ⚠️
api/core/v1alpha1/zz_generated.deepcopy.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   34.13%   34.27%   +0.13%     
==========================================
  Files          15       15              
  Lines         665      674       +9     
==========================================
+ Hits          227      231       +4     
- Misses        414      417       +3     
- Partials       24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rashmigottipati rashmigottipati force-pushed the add-timestamp-clustercatalogstatus branch from df6dd1f to 9a7a079 Compare August 1, 2024 11:42
@grokspawn
Copy link
Contributor

It won't let me put a comment on it, but at https://github.com/operator-framework/catalogd/pull/334/files#diff-d446855f2187e6d61c4719c3202fcb21e4aea9b09e09f9e1d01419f341d8fc9fR51
can you update the print directive along the lines of

//+kubebuilder:printcolumn:name=UnpackedTime,type=date,JSONPath=`.metadata.catalogContentTimestamp

Totally flexible about the name ... but Age doesn't seem right here to me.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
@rashmigottipati rashmigottipati force-pushed the add-timestamp-clustercatalogstatus branch from 0f4bb34 to 907df6f Compare August 15, 2024 16:07
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 15, 2024
@rashmigottipati rashmigottipati force-pushed the add-timestamp-clustercatalogstatus branch 2 times, most recently from ac8f6aa to b5e7d4a Compare August 21, 2024 14:18
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me based on my understanding of the goals of this PR.

@rashmigottipati rashmigottipati force-pushed the add-timestamp-clustercatalogstatus branch from b5e7d4a to de3210f Compare August 22, 2024 14:01
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
@rashmigottipati
Copy link
Member Author

Merging this PR since it was approved. upgrade-e2e will fail until a new release of catalogd is cut with the gvk updates.

@rashmigottipati rashmigottipati added this pull request to the merge queue Aug 22, 2024
Merged via the queue into operator-framework:main with commit 3b4c5f6 Aug 22, 2024
12 of 13 checks passed
@rashmigottipati rashmigottipati deleted the add-timestamp-clustercatalogstatus branch August 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capture catalog content timestamp in ClusterCatalogStatus
5 participants