Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add upgrade e2e tests #314

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ankitathomas
Copy link
Contributor

Testing upgrade from the latest release to the current commit.

Fixes #271

@ankitathomas ankitathomas requested a review from a team as a code owner July 16, 2024 14:04
@ankitathomas ankitathomas changed the title ✨ Add upgrade e2e tests WIP: ✨ Add upgrade e2e tests Jul 16, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.23%. Comparing base (13002de) to head (1a98d62).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   33.53%   34.23%   +0.70%     
==========================================
  Files          15       15              
  Lines         656      663       +7     
==========================================
+ Hits          220      227       +7     
  Misses        413      413              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
test/tools/imageregistry/pre-upgrade-setup.sh Outdated Show resolved Hide resolved
@ankitathomas ankitathomas changed the title WIP: ✨ Add upgrade e2e tests ✨ Add upgrade e2e tests Jul 17, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2024
m1kola
m1kola previously approved these changes Jul 18, 2024
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few comments - I would say they are non-blocking.

However I see that the job itself failed: for some reason ginkgo can't be found.

test/e2e/util.go Outdated Show resolved Hide resolved
test/e2e/util.go Outdated Show resolved Hide resolved
test/e2e/util.go Outdated Show resolved Hide resolved
test/upgrade/unpack_test.go Outdated Show resolved Hide resolved
@ankitathomas ankitathomas force-pushed the upgrade branch 2 times, most recently from a71f263 to e9459f9 Compare July 19, 2024 08:15
@ankitathomas ankitathomas changed the title ✨ Add upgrade e2e tests WIP: ✨ Add upgrade e2e tests Jul 19, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
@ankitathomas ankitathomas force-pushed the upgrade branch 13 times, most recently from 950b618 to a382c60 Compare July 19, 2024 10:46
@ankitathomas ankitathomas changed the title WIP: ✨ Add upgrade e2e tests ✨ Add upgrade e2e tests Jul 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
Makefile Outdated Show resolved Hide resolved
@ankitathomas ankitathomas force-pushed the upgrade branch 4 times, most recently from 0b6297f to 8994030 Compare July 19, 2024 15:22
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but it looks like this test is failing. Have you had a chance to debug why it is failing?

@ankitathomas ankitathomas force-pushed the upgrade branch 17 times, most recently from efe2cb2 to a8e0b5b Compare July 22, 2024 19:20
Signed-off-by: Ankita Thomas <[email protected]>
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @ankitathomas !

@everettraven everettraven added this pull request to the merge queue Jul 22, 2024
Merged via the queue into operator-framework:main with commit 0cdf2dc Jul 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[epic] Implement upgrade tests for Catalogd
3 participants