-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add upgrade e2e tests #314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 33.53% 34.23% +0.70%
==========================================
Files 15 15
Lines 656 663 +7
==========================================
+ Hits 220 227 +7
Misses 413 413
Partials 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a few comments - I would say they are non-blocking.
However I see that the job itself failed: for some reason ginkgo can't be found.
a71f263
to
e9459f9
Compare
950b618
to
a382c60
Compare
0b6297f
to
8994030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but it looks like this test is failing. Have you had a chance to debug why it is failing?
efe2cb2
to
a8e0b5b
Compare
Signed-off-by: Ankita Thomas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @ankitathomas !
Testing upgrade from the latest release to the current commit.
Fixes #271