Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SONAME of libzfs and libzpool before 2.3.0 release #16609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Harry-Chen
Copy link
Contributor

Motivation and Context

The ABI of libzfs and libzpool have breaking changes since last SONAME bump in commit fe6babc:

  • libzfs: zpool_print_unsup_feat removed (used by zpool cmd).
  • libzpool: multiple ddt_* symbols removed (used by zdb cmd), and many more.

Bump them to avoid ABI breakage.

See: #11817

cc @behlendorf

Description

See my commits. And here's the dpkg-gensymbols output comparing symbols from 2.3.0-rc1 to 2.2.6, for reference:

zfs-symbols.patch

How Has This Been Tested?

Compiled on my machine. Wait for CI run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

The ABI of libzfs and libzpool have breaking changes since last
SONAME bump in commit fe6babc:

* libzfs: `zpool_print_unsup_feat` removed (used by zpool cmd).
* libzpool: multiple `ddt_*` symbols removed (used by zdb cmd).

Bump them to avoid ABI breakage.

See: openzfs#11817
ZFS-CI-Type: quick
Signed-off-by: Shengqi Chen <[email protected]>
@satmandu
Copy link
Contributor

satmandu commented Oct 6, 2024

Do any of the ABI changes affect programs shipped outside of OpenZFS (i.e., are any external consumers affected?)?

I assume that zpool and zdb are always packaged with OpenZFS, so they will always be packaged with a corresponding libzfs and libzpool and thus never break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants