libzutil: allow to display powers of 1000 bytes #16579
Draft
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcassette
force-pushed
the
kbyte-1000
branch
2 times, most recently
from
cf8b4fd
to
7516b6b
Compare
ZFS displays bytes with K/M/G/T/P/E prefixes. They represent powers of 1024 bytes, i.e. KiB, MiB, GiB, TiB, PiB, EiB. Some users may want these prefixes to represent powers of 1000 bytes, i.e. KB, MB, GB, TB, PB, EB. This adds the new unit format and allows to use such display by defining an environment variable. Signed-off-by: Julien Cassette <[email protected]>
jcassette
force-pushed
the
kbyte-1000
branch
from
7516b6b
to
89ef8f6
Compare
mcmilk
suggested changes
Sep 29, 2024
|
|
||
| const int k_unit[] = { [ZFS_NICENUM_1024] = 1024, | ||
| [ZFS_NICENUM_BYTES] = 1024, | ||
| [ZFS_NICENUM_TIME] = 1000}; | ||
| [ZFS_NICENUM_TIME] = 1000, | ||
| [ZFS_NICENUM_BYTES_1000] = 1000}; |
There was a problem hiding this comment.
Would ZFS_NICENUM_1000 be a better fit?
| @@ -180,5 +184,9 @@ zfs_niceraw(uint64_t num, char *buf, size_t buflen) | |||
| void | |||
| zfs_nicebytes(uint64_t num, char *buf, size_t buflen) | |||
| { | |||
| zfs_nicenum_format(num, buf, buflen, ZFS_NICENUM_BYTES); | |||
| if (getenv("ZFS_KB_IS_1000") != NULL) { | |||
There was a problem hiding this comment.
You intruduce a new environment variable, but there is no documentation about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ZFS displays bytes with K/M/G/T/P/E prefixes. They represent powers of 1024 bytes, i.e. KiB, MiB, GiB, TiB, PiB, EiB.
Some users may want these prefixes to represent powers of 1000 bytes, i.e. KB, MB, GB, TB, PB, EB.
Description
This adds the new unit format and allows to use such display by defining an environment variable.
How Has This Been Tested?
Not tested. If this draft gathers interest then I will add tests.
Types of changes
Checklist:
Signed-off-by.