Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2] freebsd: spa taskq config fixes #15754

Merged
merged 3 commits into from
Jan 16, 2024
Merged

[2.2] freebsd: spa taskq config fixes #15754

merged 3 commits into from
Jan 16, 2024

Commits on Jan 12, 2024

  1. freebsd: fix compile for spa_taskq_read/spa_taskq_write params 

    Missed in openzfs#15695, backporting openzfs#15675.

Signed-off-by: Rob Norris <[email protected]>
    @robn
    robn committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    764d66e View commit details
    Browse the repository at this point in the history

  2. spa: Fix FreeBSD sysctl handlers 

    sbuf_cpy() resets the sbuf state, which is wrong for sbufs allocated by
sbuf_new_for_sysctl().  In particular, this code triggers an assertion
failure in sbuf_clear().

Simplify by just using sysctl_handle_string() for both reading and
setting the tunable.

Fixes: 6930ecb ("spa: make read/write queues configurable")
Reviewed-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reported-by: Peter Holm <[email protected]>
Signed-off-by: Mark Johnston <[email protected]>
Closes openzfs#15719
    @markjdb @robn
    markjdb authored and robn committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    4c1d5f4 View commit details
    Browse the repository at this point in the history

  3. spa: Let spa_taskq_param_get()'s addition of a newline be optional 

    For FreeBSD sysctls, we don't want the extra newline, since the
sysctl(8) utility will format strings appropriately.

Reviewed-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reported-by: Peter Holm <[email protected]>
Signed-off-by: Mark Johnston <[email protected]>
Closes openzfs#15719
    @markjdb @robn
    markjdb authored and robn committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    1cd8927 View commit details
    Browse the repository at this point in the history