Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go lint errors #2235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

luc99hen
Copy link
Member

What type of PR is this?

/kind enhancement

fix issue #2234

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@luc99hen luc99hen requested a review from a team as a code owner December 23, 2024 06:01
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 48.63014% with 75 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (ab990e8) to head (ab431c9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...troller/platformadmin/platform_admin_controller.go 26.92% 19 Missing ⚠️
...roller/yurtstaticset/yurt_static_set_controller.go 21.42% 11 Missing ⚠️
...ordinator/cert/yurt_coordinator_cert_controller.go 11.11% 8 Missing ⚠️
...ger/controller/raven/dns/gateway_dns_controller.go 0.00% 6 Missing ⚠️
...rtcoordinator/podbinding/pod_binding_controller.go 60.00% 4 Missing ⚠️
.../daemonpodupdater/daemon_pod_updater_controller.go 25.00% 3 Missing ⚠️
...rnalservice/gateway_internal_service_controller.go 0.00% 3 Missing ⚠️
...publicservice/gateway_public_service_controller.go 0.00% 3 Missing ⚠️
...cetopology/endpoints/endpoints_enqueue_handlers.go 0.00% 3 Missing ⚠️
...gy/endpointslice/endpointslice_enqueue_handlers.go 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
- Coverage   45.31%   45.29%   -0.02%     
==========================================
  Files         406      406              
  Lines       27890    27899       +9     
==========================================
  Hits        12637    12637              
- Misses      14014    14023       +9     
  Partials     1239     1239              
Flag Coverage Δ
unittests 45.29% <48.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luc99hen
Copy link
Member Author

@rambohe-ch @zyjhtangtang PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant