Add python version of tilers #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Wovchena please have a look at python stuff. IS tiler is not fully finished (XAI is lacking). Also, tests are missing. |
Wovchena
requested changes
Jul 3, 2023
| map_pixel = cls_map[hi, wi] | ||
| merged_pixel = merged_map[class_idx][y_1 + hi, x_1 + wi] | ||
| if merged_pixel != 0: | ||
| merged_map[class_idx][y_1 + hi, x_1 + wi] = 0.5 * (map_pixel + merged_pixel) |
There was a problem hiding this comment.
It seems that the first elements of saliency_maps[1:] are going to have smaller weights compared to the last elements if more that 2 maps overlap at any pixel. The last elem has weight 0.5, the previous 0.25 etc. Is this intentional?
There was a problem hiding this comment.
Yes, that's a heuristic for merging. Max looks more natural, but during the initial experiments it produced more artifacts. I'll have a look at this one more time.
|
@Wovchena please, have a look at tests implementation. CPP tests currently just skip tiling models. |
Wovchena
approved these changes
Jul 7, 2023
model_api/python/openvino/model_api/tilers/instance_segmentation.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting