Adding CI target for functional tests and related vars #931
Conversation
Signed-off-by: Jiri Podivin <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpodivin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| @@ -170,6 +175,10 @@ golangci-lint: | |||
| .PHONY: test | |||
| test: manifests generate gowork fmt vet envtest ginkgo ginkgo-run ## Run ginkgo tests with dependencies. | |||
|
|
|||
| .PHONY: test-ci | |||
| test-ci: GINKGO_ARGS = $(GINKGO_CI_ARGS) | |||
There was a problem hiding this comment.
do we need a new target for this? can't we just set different GINKGO_ARGS in the CI job?
There was a problem hiding this comment.
That was my original suggestion. But it was pointed out that we would have to submit PR to release repo every time we would want to change anything about the way ginkgo runs, say number of repetitions.
There was a problem hiding this comment.
ah ok, so maybe we should get some review of those who requested it?
There was a problem hiding this comment.
They are on the list.
Dependency of openshift/release#53105