Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "[ovn-controller] Don't create ovn-controller if nicMappings" #1104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

averdagu
Copy link
Contributor

@averdagu averdagu commented Sep 27, 2024

This is the same patch that was merged a couple of days ago (seen on PR#1070).
This commit blocked adoption gates so it got reverted (on PR#1103), more
information about problem on the description.

Recreating PR to be able to test changes done in ovn-operator (PR#352) while
we fix the error uncover with this patch.

Depends-on: openstack-k8s-operators/ovn-operator#352

#1070
#1103
openstack-k8s-operators/ovn-operator#352

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: averdagu
Once this PR has been reviewed and has the lgtm label, please assign rebtoor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35784b204bcc4f0fbe05418d765a9550

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 09m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 49s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 27s
openstack-operator-tempest-multinode FAILURE in 1h 50m 14s

@averdagu averdagu changed the title [WIP][dnm] Reapply "[ovn-controller] Don't create ovn-controller if nicMappings" Reapply "[ovn-controller] Don't create ovn-controller if nicMappings" Sep 30, 2024
@averdagu
Copy link
Contributor Author

recheck

…empty"

This reverts commit ba9d53e.

This commit was reverted the first time as it broke the adoption gates
since a config map needed by edpm deployment was not being generated
by ovn-controller.

This is fixed on ovn-operator PR#352, hence this commit can be
reverted.

Depends-on: openstack-k8s-operators/ovn-operator#352
@booxter
Copy link
Contributor

booxter commented Oct 1, 2024

The patch is ok but we'll need to wait for the ovn-operator part to land first.

@booxter
Copy link
Contributor

booxter commented Oct 1, 2024

     logger.go:42: 11:01:36 |  | Error from server (InternalError): error when creating "https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml": Internal error occurred: failed calling webhook "mnetconfig.kb.io": failed to call webhook: Post "https://infra-operator-controller-manager-service.openstack-operators.svc:443/mutate-network-openstack-org-v1beta1-netconfig?timeout=10s": no endpoints available for service "infra-operator-controller-manager-service" 

@booxter
Copy link
Contributor

booxter commented Oct 1, 2024

/retest-required

@averdagu
Copy link
Contributor Author

averdagu commented Oct 5, 2024

Kuttl tests failed with:
logger.go:42: 18:57:46 | ctlplane-tls-custom-issuers/7- | nova-internal.openstack-kuttl-tests.svc:8774 issued by , expected issuer=CN=rootca-internal
It seems a valid error but should not be affected by this patch, will recheck again to see if it was a one-time error (also on previous patches kuttl test didn't fail IIRC).
PS: Since ovn-operator patch was already merged, will try to run an adoption test to make sure it won't break (again) the gate.

@averdagu
Copy link
Contributor Author

averdagu commented Oct 5, 2024

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants