Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This change ensures the baremetal-operator is built with FIPS compliance #125

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Feb 6, 2024

  • Changed the build image to ubi9/go-toolkit
  • Changed the base image to ubi9/minimal
  • Added the default GO_BUILD_EXTRA_ARGS="-tags strictfipsruntime"
  • Added the GO_BUILD_EXTRA_ENV_ARGS build argument to allow custom build arguments at build time. It defaults to "CGO_ENABLED=1 GO111MODULE=on"
  • Those default parameters have been added to enable FIPS compliance
  • Fixed indentation in Dockerfile
  • Removed TARGETOS and TARGETARCH env vars.
  • Added DOCKER_BUILD_ARGS variable in Makefile to pass custom parameters during podman build
  • Added export FAIL_FIPS_CHECK=true in .prow_ci.env file to enable FIPS tests on prow

Closes: https://issues.redhat.com/browse/OSPRH-3375

- Changed the build image to ubi9/go-toolkit
- Changed the base image to ubi9/minimal
- Added the default GO_BUILD_EXTRA_ARGS="-tags strictfipsruntime"
- Added the GO_BUILD_EXTRA_ENV_ARGS build argument to allow custom build arguments at build time.
  It defaults to "CGO_ENABLED=1 GO111MODULE=on"
- Those default parameters have been added to enable FIPS compliance
- Fixed indentation in Dockerfile
- Removed TARGETOS and TARGETARCH env vars.
- Added DOCKER_BUILD_ARGS variable in Makefile to pass custom parameters during podman build
- Added export FAIL_FIPS_CHECK=true in .prow_ci.env file

Closes: https://issues.redhat.com/browse/OSPRH-3375

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor requested review from rabi and steveb February 6, 2024 15:14
@openshift-ci openshift-ci bot requested review from abays and stuggi February 6, 2024 15:15
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2024
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2024
@abays
Copy link
Contributor

abays commented Feb 7, 2024

Not sure if this is a hiccup or not:

Error from server (AlreadyExists): error when creating "/alabama/install_yamls/out/openstack-operators/namespace.yaml": namespaces "openstack-operators" already exists

...but trying again to check

/test openstack-baremetal-operator-build-deploy

@openshift-merge-bot openshift-merge-bot bot merged commit 9d2c03c into openstack-k8s-operators:main Feb 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants