Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.4 #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

openstack-k8s-ci-robot
Copy link

@openstack-k8s-ci-robot openstack-k8s-ci-robot commented Sep 26, 2024

This PR contains the following updates:

Package Type Update Change
github.com/k8snetworkplumbingwg/network-attachment-definition-client require minor v1.4.0 -> v1.7.4
github.com/k8snetworkplumbingwg/network-attachment-definition-client indirect minor v1.4.0 -> v1.7.4

Release Notes

k8snetworkplumbingwg/network-attachment-definition-client (github.com/k8snetworkplumbingwg/network-attachment-definition-client)

v1.7.4

Compare Source

This release accounts for CNI plugins which do not use the sandbox field in results when calculating the network-status annotation, doing so for backwards compatibility for plugins which choose to not use this field (such as Calico)

v1.7.3

Compare Source

This release accounts for the sandox interfaces when reporting the interfaces in the network-status annotation; in case the CreateNetworkStatuses clients invoke it with a CNI result featuring non-sandbox interfaces as the first item in the list, this release accounts for that condition.

v1.7.2

Compare Source

When the CreateNetworkStatuses method was created to properly set the network-status annotation when a CNI result includes multiple interfaces in the return, it was found that it when setting the "default" parameter in the network-status, it was setting it to all the returned interfaces to true, which doesn't fit the NPWG net-attach-def specification.

This release fixes that issue by using the first interface in the CNI result set to "default": true for the cluster default network and not the following interfaces.

NOTE Do not use this version, use >= v1.7.3

v1.7.1

Compare Source

Adds the CreateNetworkStatuses method to properly set the network-status annotation when a CNI result includes multiple interfaces in the return.

For details of the before/after, see this gist: https://gist.github.com/dougbtv/1eb8ac2d61d494b56d65a6b236a86e61

For the related suggested update to the NPWG net-attach-def specification (for clarity only), see this proposal @​ https://docs.google.com/document/d/1DUTV-o6E6zlRTKZkxeDhAeyGrmq03qPgPbU580Rm7-g/edit

v1.7.0

Compare Source

Adds MTU to network-status

v1.6.0

Compare Source

Adds IPAMClaimReference to network-selection-elements

v1.5.0

Compare Source

What's Changed
New Contributors

Full Changelog: k8snetworkplumbingwg/network-attachment-definition-client@v1.4.0...v1.5.0


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openstack-k8s-ci-robot
Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openstack-k8s-ci-robot openstack-k8s-ci-robot changed the title fix(deps): update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.3 fix(deps): update module github.com/k8snetworkplumbingwg/network-attachment-definition-client to v1.7.4 Oct 5, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/network-attachment-definition-client branch from ff7c17f to e45f4a2 Compare October 5, 2024 04:19
Copy link
Contributor

openshift-ci bot commented Oct 5, 2024

@openstack-k8s-ci-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/keystone-operator-build-deploy-kuttl e45f4a2 link true /test keystone-operator-build-deploy-kuttl
ci/prow/functional e45f4a2 link true /test functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant