Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment.go code #365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bshephar
Copy link
Collaborator

This change does some refactoring of the deployment.go code to avoid overuse of string literals and replace with consts. Along with moving excessive code from the main Deployment function into dedicated functions that are easier to test and read.

This change does some refactoring of the deployment.go code to avoid
overuse of string literals and replace with consts. Along with moving excessive code
from the main Deployment function into dedicated functions that are easier to test
and read.

Signed-off-by: Brendan Shephard <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshephar
Copy link
Collaborator Author

/test horizon-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Sep 21, 2024

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/horizon-operator-build-deploy-kuttl 574ee2a link true /test horizon-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant