Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 in local_settings.py get_pod_ip() #315

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Apr 9, 2024

@openshift-ci openshift-ci bot requested review from abays and stuggi April 9, 2024 17:43
@hjensas hjensas marked this pull request as draft April 9, 2024 17:47
@hjensas
Copy link
Contributor Author

hjensas commented Apr 9, 2024

So, this is wrong - we want the POD IP - not resolving horizon-openstack.apps ...

@hjensas
Copy link
Contributor Author

hjensas commented Apr 9, 2024

So, this is wrong - we want the POD IP - not resolving horizon-openstack.apps ...

Done.

Copy link
Collaborator

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, hjensas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bc96961 into openstack-k8s-operators:main Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants