Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route lookup and update status.endpoint #223

Closed

Conversation

bshephar
Copy link
Collaborator

This commit adds a route lookup and then uses the returned value to update the instance.Status.Endpoint value.

❯ oc get horizon horizon -o yaml | yq .status.endpoint
horizon-openstack-operators.apps.okd.bne-shift.net

Before this change, it is defaulting to the Kubernetes service name which doesn't provide much value for the end user.

This commit adds a route lookup and then uses the returned value to
update the instance.Status.Endpoint value.

Signed-off-by: Brendan Shephard <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Sep 29, 2023

we don't want the service operators to depend on routes if possible. #224 was missing in horizon operator that the openstack-operator correct passes in the endpointURL via the override. if there is no openstack-operator, or if a loadbalancer service gets used for the public endpoints it is correct that the endpoint is a service url

@bshephar bshephar closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants