-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend liveness probe timing #156
Extend liveness probe timing #156
Conversation
be40c02
to
74d33e0
Compare
If this failure happens during the initial deployment, I wonder if it would be prudent to consider adding a startup probe [1]? |
The Horizon pod is fairly frequently killed due to the current liveness probe timing. This seems to happen more frequently during the initial deployment while the system is under load. This change adds the startup probe to provide some extra time for kubelet to validate the functionality of the Horizon pod before terminating it. Signed-off-by: Brendan Shephard <[email protected]>
74d33e0
to
e0abf14
Compare
Sounds reasonable. Let's give it a run and see how it goes. I changed my commit to reflect this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fb6d1d7
into
openstack-k8s-operators:main
The Horizon pod is fairly frequently killed due to the current liveness probe timing. This seems to happen more frequently during the initial deployment while the system is under load. This change extends the liveness probe to provide some extra time for kubelet to validate the functionality of the Horizon pod before terminating it.