Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bind configuration #224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beagles
Copy link
Collaborator

@beagles beagles commented Sep 20, 2024

This patch gets bind up and running as a statefulset, tidying up the configuration files and making use of the per-bind rndc key generation implemented in an earlier patch.

Certain elements will require some further strict testing such as injecting name server options and setting up logging customizations.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beagles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@beagles
Copy link
Collaborator Author

beagles commented Sep 20, 2024

/test all

@beagles
Copy link
Collaborator Author

beagles commented Sep 20, 2024

/test all

Copy link
Contributor

@omersch381 omersch381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and questions I had while going over the draft

pkg/designatebackendbind9/service.go Outdated Show resolved Hide resolved
pkg/designatebackendbind9/volumes.go Outdated Show resolved Hide resolved
pkg/designatebackendbind9/volumes.go Show resolved Hide resolved
pkg/designatebackendbind9/volumes.go Show resolved Hide resolved
templates/designatebackendbind9/bin/namedpoddetails.py Outdated Show resolved Hide resolved
templates/designatebackendbind9/bin/namedpoddetails.py Outdated Show resolved Hide resolved
templates/designatebackendbind9/config-named/logging.conf Outdated Show resolved Hide resolved
@beagles
Copy link
Collaborator Author

beagles commented Sep 24, 2024

held for a bit to finish a few extra tests.

This patch gets bind up and running as a statefulset, tidying up the
configuration files and making use of the per-bind rndc key generation
implemented in an earlier patch.

Certain elements will require some further strict testing such as
injecting name server options and setting up logging customizations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants