Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift image has the NVMe
hostid
andhostnqn
hardcoded, so it ends up being the same in all the control plane nodes, which is problematic.This
MachineConfig
fixes this issue by recreating both files when thehostid
doesn't match the system-uuid of the machine it is running on.Bugs:
/usr/etc/nvme/hostid
/usr/etc/nvme/hostnqn
openshift/os#1519