Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend samples using custom images #416

Merged

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jul 10, 2024

Te way custom images are specified has changed, and now it no longer uses the containerImage file in the cinder sections but instead needs to be specified in the OpenStackVersion.

This patch updates the examples to match the latest code.

Copy link
Contributor

@ASBishop ASBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Akrog
Copy link
Contributor Author

Akrog commented Sep 19, 2024

/retest

The way custom images are specified has changed, and now it no longer
uses the `containerImage` file in the cinder sections but instead needs
to be specified in the `OpenStackVersion`.

This patch updates the examples to match the latest code.
Copy link
Contributor

@ASBishop ASBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2024
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, ASBishop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d5463f6 into openstack-k8s-operators:main Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants