DBSync: Bump service versions #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adopting the cinder services we end up with the services getting pinned to the old RPC and OVO versions, and to fix that we would need to restart the services. This is the standard rolling upgrades mechanism. Since the adoption is more like an offline update/upgrade we need to bump these versions in the DB before we start them so they all start with the right versions. The `cinder-manage db sync` command has a flag specifically designed for this purpose: `--bump-versions` This patch adds this flag to the job that syncs the DB. Once we start working on updates and upgrades we'll have to revisit this to see if we need to tweak it or not.
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, Akrog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
openshift-merge-robot
merged commit c972735
into
openstack-k8s-operators:main
2 checks passed
ASBishop
pushed a commit
to ASBishop/cinder-operator
that referenced
this pull request
Mar 11, 2024
…_galera Default Galera to enabled=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adopting the cinder services we end up with the services getting pinned to the old RPC and OVO versions, and to fix that we would need to restart the services. This is the standard rolling upgrades mechanism.
Since the adoption is more like an offline update/upgrade we need to bump these versions in the DB before we start them so they all start with the right versions.
The
cinder-manage db synccommand has a flag specifically designed for this purpose:--bump-versionsThis patch adds this flag to the job that syncs the DB.
Once we start working on updates and upgrades we'll have to revisit this to see if we need to tweak it or not.