Make sure set_openstack_container is less depedent on instal_yamls #2389
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
Cleanup set_openstack_container role by setting default values and omitting setting fact if install_yamls was not used during deployment. This is first atempt of reducing dependency of set_openstack_container role from install_yamls. The work that is left for later is for updating envs in operators other than openstack-operator. Task that waits for an operator update to complete will only work in install_yaml deployed enviroments and is skipped in architecture_scenario context.
ciecierski
force-pushed
the
set_openstack_container_refactor
branch
from
f77c00f
to
28d3947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup set_openstack_container role by setting default values and omitting
setting fact if install_yamls was not used during deployment.
This is first atempt of reducing dependency in set_openstack_container role
from install_yamls. The work that is left for later is for updating
ENVs in operators other than openstack-operator. Task that waits
for an operator update to complete will only work in install_yaml deployed
environments and is skipped in architecture_scenario context.
Jira: https://issues.redhat.com/browse/OSPRH-10285