[enterprise-4.9] Adding OSD and ROSA to the Travis configuration #40592
Conversation
openshift-ci
bot
added
the
size/XS
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 254f8f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61e18e27a30059000800c5dd 😎 Browse the preview: https://deploy-preview-40592--osdocs.netlify.app |
pneedle-rh
changed the title
pneedle-rh
changed the title
pneedle-rh
force-pushed
the
adding-osd-and-rosa-to-travis-config-4-9
branch
from
7a79f81
to
69b04ee
Compare
pneedle-rh
added
branch/enterprise-4.9
peer-review-needed
pneedle-rh
added
the
do-not-merge/hold
pneedle-rh
force-pushed
the
adding-osd-and-rosa-to-travis-config-4-9
branch
from
69b04ee
to
254f8f9
Compare
|
@pneedle-rh Great catch and these changes LGTM. I'm personally not sure about the impact on other uses for the |
| @@ -14,6 +14,8 @@ install: | |||
|
|
|||
| script: | |||
| - python3 build.py --distro openshift-enterprise --product "OpenShift Container Platform" --version 4.9 --no-upstream-fetch && python3 makeBuild.py | |||
| - python3 build.py --distro openshift-dedicated --product "OpenShift Dedicated" --version 4 --no-upstream-fetch && python3 makeBuild.py | |||
| - python3 build.py --distro openshift-rosa --product "Red Hat OpenShift Service on AWS" --version 4 --no-upstream-fetch && python3 makeBuild.py | |||
|
|
|||
| after_success: | |||
There was a problem hiding this comment.
We might also need to determine what constitutes a success if multiple distro builds are being run. Would one successful build cause the automerge to take place, or would all of the build.py runs need to succeed? How can we test this in Travis?
|
@gaurav-nelson thanks for #40741. That is a much better solution that the one I proposed here, so I am closing this PR as obsoleted by your PR. Thanks again! |
This applies to
enterprise-4.9only. #40591 is a separate PR formainandenterprise-4.9.This pull request adds the OSD and ROSA collections to the Travis checks. Related PR #40587 was created to test the checks for the two collections.
The PR also updates the
build.pyscript which is called in the.travis.ymlfile. The addition cleans thedrupal-builddirectory in the Travis VM that is running the checks, rather than just cleaning the distro subdirectory within thedrupal-builddirectory. Without this change, each successivepython build.py...command in thetravis.ymlfile will build all of the distros that have been built so far, because the remnants of the previous run continues to exist in thedrupal-builddirectory in the Travis VM.My understanding is that, in
enterprise-4.9, thebuild.pyscript is only called from the.travis.ymlfile. The sync scripts I think use thebuild_for_portal.pyfile instead. Please let me know if the change in this PR might impact other uses for thebuild.pyfile that I don't know about. I.e. is there any reason why the previous builds for a different distro might need to remain in thedrupal-builddirectory after thebuild.pyscript has run?We might also need to determine what constitutes a success if multiple distro builds are being run. Would one successful build cause the auto-merge to take place, or would all of the
build.pyruns need to succeed? How can we test this in Travis?