[DO-NOT-MERGE-YET] turn on pprof in core controller to allow for goroutine dumps #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per the golang recommendations that pprof enablement is OK in production, we are enabling to allow for gathering goroutine dumps as part of diagnosing deadlocks. rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
gabemontero
commented
Jul 12, 2024
| @@ -87,6 +87,14 @@ spec: | |||
| options: | |||
| disabled: false | |||
| configMaps: | |||
| config-observability: | |||
| data: | |||
| metrics.count.enable-reason: 'false' | |||
There was a problem hiding this comment.
all the metrics props are defaults I have observed once we are deployed
I will run comparisons to confirm/deny whether tekton config application is an add/merge or a replace type of operation
gabemontero
changed the title
|
lgtm. Feel free to merge. |
rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
thanks @enarha unfortunately with local testing I cannot get goroutine dumps from the pipeline controller like I can with the results watcher, even though AFAIU I'm configuring the same way via the config-observability config map. been debugging a bit, will a bit more, but may reach out on #team-ocp-pipelines for some help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per the golang recommendations that pprof enablement is OK in production, we are enabling to allow for gathering goroutine dumps as part of diagnosing deadlocks.
rh-pre-commit.version: 2.3.0
rh-pre-commit.check-secrets: ENABLED