Improve Pulsar AWS deployment (terraform + ansible) #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: toziegler Replace the outdated terrafrom-inventory plugin with the Ansible Provider and the Terraform Ansible-Collection Add a new variable to deploy instances as AWS spot instances
Co-authored-by: toziegler When deploying AWS instances, with every re-boot the label of NVMe devices changes. E.g., `/dev/nvme1n1`, `/dev/nvme0n1` Hence, hard-coding the disk labels leads to failed deployments when, e.g., `/dev/nvme1n1` is used as boot disk. By discovering storage devices with ansible we can dynamically select available storage devices for pulsar/bookkeeper
Co-authored-by: toziegler When network connectivity is slow, uploading the benchmark code to nodes via ansible takes long and is not required if the step has been performed before. By splitting the copy and rename step and using `creates` we can prevent multiple (slow) uploads.
Co-authored-by: toziegler For long running benchmarks on-demand instances is a more meaningful default value
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 5 days if no further activity occurs. Thank you for your contributions. |
|
Hi @merlimat, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the deployment of Pulsar on AWS using Terraform and Ansible, incorporating several improvements and optimizations:
Prevent redundant benchmark code uploads: Optimized benchmark code deployment by splitting and using creates to avoid unnecessary uploads.
Dynamic discovery of storage devices: Replaced hardcoded disk labels with Ansible-based discovery, ensuring reliable deployment across AWS instances where device labels may change post-reboot.
Replace terraform-inventory with Ansible Provider and support for spot instances
Upgraded to Ansible Provider and Terraform Ansible-Collection, retiring outdated terraform-inventory plugin.
Introduced support for deploying instances as AWS spot instances via a new configurable variable (default = False).
These changes collectively enhance deployment reliability and introduce flexibility in instance provisioning for Pulsar and Bookkeeper deployments on AWS.